Chore: Color Overlay Filter Deprecations #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bbazukun123
commented
Feb 8, 2024
bbazukun123
commented
- Add deprecations for the Color Overlay filter.
- Use GpuProgram.from and GlProgram.from for caching.
bigtimebuddy
reviewed
Feb 8, 2024
| constructor(options: ColorOverlayFilterOptions = {}) | ||
| constructor(options?: ColorOverlayFilterOptions); | ||
| /** | ||
| * @deprecated since 8.0.0 |
There was a problem hiding this comment.
Suggested change
| * @deprecated since 8.0.0 | |
| * @deprecated since 6.0.0 |
| if (typeof options === 'number' || Array.isArray(options) || options instanceof Float32Array) | ||
| { | ||
| // eslint-disable-next-line max-len | ||
| deprecation(v8_0_0, 'ColorOverlayFilter constructor params are now options object. See params: { color, alpha }'); |
There was a problem hiding this comment.
Suggested change
| deprecation(v8_0_0, 'ColorOverlayFilter constructor params are now options object. See params: { color, alpha }'); | |
| deprecation('6.0.0', 'ColorOverlayFilter constructor params are now options object. See params: { color, alpha }'); |
|
|
||
| options = { color: options }; | ||
|
|
||
| if (args[1]) options.alpha = args[1]; |
There was a problem hiding this comment.
Suggested change
| if (args[1]) options.alpha = args[1]; | |
| if (args[1] !== undefined) options.alpha = args[1]; |
Comment on lines
1
to
2
| // eslint-disable-next-line camelcase | ||
| import { Color, ColorSource, deprecation, Filter, GlProgram, GpuProgram, UniformGroup, v8_0_0 } from 'pixi.js'; |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line camelcase | |
| import { Color, ColorSource, deprecation, Filter, GlProgram, GpuProgram, UniformGroup, v8_0_0 } from 'pixi.js'; | |
| import { Color, ColorSource, deprecation, Filter, GlProgram, GpuProgram, UniformGroup } from 'pixi.js'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.