Chore: Emboss Filter Tweaks #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bbazukun123
commented
Feb 8, 2024
bbazukun123
commented
- Simplify single param option.
- Use GpuProgram.from and GlProgram.from for caching.
This is mainly to align with the other single-option filters, but I'm happy to go the opposite way if that is more logical 👍 |
bigtimebuddy
approved these changes
Feb 14, 2024
|
I think keeping consistent with v5 is best. So probably the single option. If we want to add more options to this filter, then we can change it. Pixelation filter also has a single option for size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.