Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Old Film Filter Tweaks #429

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

bbazukun123
Copy link
Collaborator

  • Add deprecations for the Old Film filter.
  • Use GpuProgram.from and GlProgram.from for caching.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prop name changes seems unnecessary. I'm not sure what problem it's solving or what the rationale is other than a stylistic choice. I'm in favor of keeping this like it is. Also, none of this is deprecated, so this is not backward compatible.

@bbazukun123
Copy link
Collaborator Author

The prop name changes seems unnecessary. I'm not sure what problem it's solving or what the rationale is other than a stylistic choice. I'm in favor of keeping this like it is. Also, none of this is deprecated, so this is not backward compatible.

So the name changes here are just reverting back to the older version's for backward compatibility. (Name changes were merged in as part of the earlier update for v8)

@bbazukun123 bbazukun123 changed the title Chore: Old Film Filter Deprecations Chore: Old Film Filter Tweaks Feb 14, 2024
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

@bigtimebuddy bigtimebuddy merged commit e8fe729 into main Feb 14, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the chore-deprecation-old-film branch February 14, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants