Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move changes of 3.3 to 3.4 #229

Open
withanage opened this issue Jan 22, 2023 · 3 comments
Open

Move changes of 3.3 to 3.4 #229

withanage opened this issue Jan 22, 2023 · 3 comments
Milestone
1.3.4.4

Comments

@withanage
Copy link
Member

No description provided.

withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
d94d133
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
3eec210
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
d0d9575
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
f5ba558
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
6c91f9a
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
1049012
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
f4d5054
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
8ddadd6
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
7038a4a
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
6581a4e
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
5eba685
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 3, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
ca342a4
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 7, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
d032a9c
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 8, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
36199ca
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 8, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
fafbdac
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 8, 2023
@withanage
pkp#229 OrcidProfilePlugin-705
38583ac
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 8, 2023
@withanage
pkp#229 OrcidProfilePlugin
8d66d49
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 11, 2023
@withanage
pkp#229 OrcidProfilePlugin
b07a3d4
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 12, 2023
@withanage
pkp#229 OrcidProfilePlugin
ef9e751
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 12, 2023
@withanage
pkp#229 OrcidProfilePlugin
e6fe39b
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 12, 2023
@withanage
pkp#229 OrcidProfilePlugin
f3042a8
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 12, 2023
@withanage
pkp#229 OrcidProfilePlugin
182d0bd
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 12, 2023
@withanage
pkp#229 OrcidProfilePlugin
f0388e5
@withanage withanage mentioned this issue Feb 12, 2023
Merged
withanage added a commit to withanage/orcidProfile that referenced this issue Feb 12, 2023
@withanage
pkp#229 OrcidProfilePlugin
763b2ea
@jonasraoni
Copy link

I just saw this XML validation issue at the build output of /main:

./plugins/generic/orcidProfile/emailTemplates.xml:14: element email: validity error : Element email does not carry attribute name
t="emails.orcidCollectAuthorId.subject" body="emails.orcidCollectAuthorId.body"/
                                                                               ^
./plugins/generic/orcidProfile/emailTemplates.xml:15: element email: validity error : Element email does not carry attribute name
AuthorAuthorization.subject" body="emails.orcidRequestAuthorAuthorization.body"/

@withanage
Copy link
Member Author

withanage commented Feb 17, 2023 •
edited
Loading

Thanks @jonasraoni
I think it is because the submodule update is not yet happened. Only the plugin was updated.

This was referenced Feb 17, 2023
Merged
Closed
Closed
@withanage withanage added this to the 1.3.4.4 milestone Mar 4, 2023
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Mar 27, 2023
@jonasraoni
pkp#229 Added missing method
8bdee64
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Mar 27, 2023
@jonasraoni
pkp#229 Typehinting
a588471
@jonasraoni
Copy link

jonasraoni commented Mar 27, 2023 •
edited
Loading

I've been doing some general fixes on OJS, and found a missing method on the plugin, here's the PR:

Only the first commit is relevant, the rest is mostly typehinting.

jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Added missing method
1311d7b
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Typehinting
83ebce7
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Updated deprecated string interpolation
9698652
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Added missing header
7d17d87
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Fixed file header
4871473
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Fixed file header
e9bb563
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Dropped plugin wrapper
89d344f
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Added missing namespace
b8b0205
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Formatting
0623ad8
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 Replaced IsoCodesFactory by Locale method
93f9ece
jonasraoni added a commit to jonasraoni/orcidProfile that referenced this issue Apr 15, 2023
@jonasraoni
pkp#229 PHP CS Fixer
f71ec26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.4.4
Development

No branches or pull requests
2 participants
@jonasraoni @withanage