Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#9456 Add user private notes #303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#9456 Add user private notes #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a94d6b6
pkp/pkp-lib#9456 Rebase for private notes
nibou230 Nov 30, 2023
6c70373
pkp/pkp-lib#9456 Add user prefix to private notes
nibou230 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/ListPanel/users/SelectReviewerListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@
</div>
<div v-html="item.gossip"></div>
</list-item>
<list-item v-if="item.userPrivateNote">
<div class="listPanel__item--reviewer__detailHeading">
{{ userPrivateNotesLabel }}
</div>
<div v-html="item.userPrivateNote"></div>
</list-item>
<list-item v-if="localize(item.biography)">
<div class="listPanel__item--reviewer__detailHeading">
{{ biographyLabel }}
Expand Down Expand Up @@ -282,6 +288,10 @@ export default {
type: String,
required: true,
},
userPrivateNotesLabel: {
type: String,
required: true,
},
item: {
type: Object,
required: true,
Expand Down
5 changes: 5 additions & 0 deletions src/components/ListPanel/users/SelectReviewerListPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"
:declined-reviews-label="declinedReviewsLabel"
:gossip-label="gossipLabel"
:user-private-notes-label="userPrivateNotesLabel"
:item="item"
:never-assigned-label="neverAssignedLabel"
:reassign-label="reassignLabel"
Expand Down Expand Up @@ -202,6 +203,10 @@ export default {
type: String,
required: true,
},
userPrivateNotesLabel: {
type: String,
required: true,
},
id: {
type: String,
required: true,
Expand Down
3 changes: 3 additions & 0 deletions src/docs/components/ListPanel/previews/PreviewSelectReviewerListPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
empty-label="No reviewers found"
:filters="filters"
gossip-label="Editorial Notes"
user-private-notes-label="Editorial Private Notes"
:items="items"
:items-max="items.length"
:last-round-reviewers="lastRoundReviewers"
Expand Down Expand Up @@ -72,6 +73,8 @@ export default {
},
gossip:
"<p>Aisla is a terrific reviewer but she takes a while to confirm and complete a review. Recommend not using her if you're on a tight deadline.</p>",
userPrivateNote:
"<p>Keep this note private. Aisla is a terrific reviewer but she takes a while to confirm and complete a review. Recommend not using her if you're on a tight deadline.</p>",
},
{
...reviewer,
Expand Down
1 change: 1 addition & 0 deletions src/docs/components/ListPanel/readme-select-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
| `emptyLabel` | A localized string to display when there are no reviewers to show in the list. |
| `filters` | An array [Filter](#/component/Filter)s. Default: `[]` |
| `gossipLabel` | A localized string for the gossip section. |
| `userPrivateNotesLabel` | A localized string for the private notes section. |
| `id` | A unique id for this component. |
| `items` | An array of reviewers. Default: `[]` |
| `itemsMax` | A count of all reviewers in the journal, press or preprint server. Default: `0` |
Expand Down