-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST ONLY]Invitation table view #382
base: main
Are you sure you want to change the base?
Conversation
ce6b33f
to
c18d239
Compare
10f08af
to
5af9570
Compare
50d2e79
to
e2b7aab
Compare
2b83095
to
23647b7
Compare
23647b7
to
c40baa1
Compare
6ff6df5
to
8b7aa7a
Compare
6f8fe87
to
2cd30b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ipula,
I did review of InvitationManager. The others are still for me to pick up next days.
Thanks!
be1ec67
to
8852037
Compare
0b8df10
to
ce7ddc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the UserInvitationManager and UserInvitationPage
There is good progress - lets keep going.
I still have AcceptInvitation to go through - but there is probably enough feedback for this week.
); | ||
if (!user) { | ||
store.updatePayload('inviteeEmail', fields.value.email); | ||
store.userSearch.message = t('userInvitation.search.userNotFound'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check with Devika - maybe we could indicate this directly on UserInvitationDetailsFormStep based on whether userId exist - I think that would be cleaner.
function updateUserForm(a, form, c, d) { | ||
set(a, form, c, d); | ||
if (form.fields) { | ||
form.fields.forEach((field) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain (probably via comments) what this logic is aiming to achieve? I would hope there is opportunity to simplify it.
if (!store.invitationPayload.userId) { | ||
userForm.value.fields.forEach((field) => { | ||
if (field.isMultilingual) { | ||
store.updatePayload( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here - it would deserve comments and check whether there is opportunity for simplification.
errors[element] = { | ||
...errors[element], | ||
[data.key]: store.errors[element + '.' + data.key], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just create general function which converts from dot notation to nested object.
@@ -3,7 +3,7 @@ | |||
<div class="py-1"> | |||
<FormDisplayItemBasic | |||
heading-element="h4" | |||
:heading="t('user.emailAddress')" | |||
:heading="t('user.email')" | |||
:value="store.email" | |||
></FormDisplayItemBasic> | |||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below I see multiple FieldText - would be possible to have these configured through the form as usual, rather than just individual Fields here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check this
b16bccd
to
5386f13
Compare
0867826
to
98f9b91
Compare
98f9b91
to
cfc78f6
Compare
No description provided.