Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.0-11? #1

Merged
merged 3 commits into from
Sep 27, 2022
Merged

version 1.0-11? #1

merged 3 commits into from
Sep 27, 2022

Conversation

TCLamnidis
Copy link
Contributor

Changes:

  • explicit calls to contamMix S3 class functions to avoid errors in certain newer versions of R.
  • more flexible multithreading, for compatibility with HPCs.

The old behaviour of contamMix to parallelise across all available cores does not scale very well for use in HPCs. By default contamMix now uses 1 core to run, unless more are requested.

I have tested the proposed changes on the HPC cluster in MPI EVA. Seems to work as intended.

NEWS has been updated to reflect the changes, but I have not touched any other part of the R package guts atm.

@plfjohnson plfjohnson merged commit 46c2b9c into plfjohnson:main Sep 27, 2022
@plfjohnson
Copy link
Owner

Thanks; merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants