Pm/display version from GitHub #977
Conversation
| @@ -5,7 +5,7 @@ | |||
| <meta charset="utf-8" /> | |||
| <link rel="icon" href="%PUBLIC_URL%/favicon.png" /> | |||
| <link href="https://fonts.googleapis.com/css?family=Mulish:400,400i,700" rel="stylesheet"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
There was a problem hiding this comment.
Do we want to have fixed size to 768 ?
There was a problem hiding this comment.
Ondrej wants app without scrollbars, so I removed this meta tag.
| text: _(t.clickHere), | ||
| onClick: (e) => { | ||
| e.preventDefault() | ||
| window.open(GITHUB_VERSION_URL, '_blank') |
There was a problem hiding this comment.
use buildInformation.releaseUrl it it set - github URL is not pretty. If empty dont put the link in widget.
There was a problem hiding this comment.
buildInformation.releaseUrl return url for current version but we want to show latest version.
There was a problem hiding this comment.
You are right - you need to read json from GITHUB_VERSION_URL to get property "html_url":
"html_url": "https://github.com/plgd-dev/hub/releases/tag/v2.7.19",There was a problem hiding this comment.
So, you wanna show github release url, no that json ;)
| @@ -25,7 +25,7 @@ const getBuildInformation = (wellKnownConfig: WellKnownConfigType) => ({ | |||
| commitHash: wellKnownConfig?.commitHash || '', | |||
| commitDate: wellKnownConfig?.commitDate || '', | |||
| releaseUrl: wellKnownConfig?.releaseUrl || '', | |||
| version: wellKnownConfig?.version || '', | |||
| version: wellKnownConfig?.version || '0.0.0', | |||
There was a problem hiding this comment.
This informations are in hub under object buildInfo:
There was a problem hiding this comment.
I want to put them the similar way also in client-application.
There was a problem hiding this comment.
So I can use it from buildInfo also in client app ?
There was a problem hiding this comment.
Yes I will move all these properties under buildInfo object:
buildDate: wellKnownConfig?.buildInfo?.buildDate || '',
commitHash: wellKnownConfig?.buildInfo?.commitHash || '',
commitDate: wellKnownConfig?.buildInfo?.commitDate || '',
releaseUrl: wellKnownConfig?.buildInfo?.releaseUrl || '',
version: wellKnownConfig?.buildInfo?.version || '0.0.0',
update dependencies
# Conflicts: # http-gateway/web/package-lock.json
update dependencies
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.