Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Add PMIx data handling utilities #20

Merged
merged 2 commits into from
Jun 2, 2017
Merged

RFC: Add PMIx data handling utilities #20

merged 2 commits into from
Jun 2, 2017

Conversation

rhc54
Copy link
Member

@rhc54 rhc54 commented May 28, 2017

Signed-off-by: Ralph Castain rhc@open-mpi.org

RFC: Add PMIx data handling utilities
fc82904 
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
@rhc54 rhc54 self-assigned this May 28, 2017
@rhc54 rhc54 requested a review from dsolt May 28, 2017 15:07
@rhc54
Copy link
Member Author

rhc54 commented May 28, 2017

Refs openpmix/openpmix#379

@rhc54 rhc54 mentioned this pull request May 28, 2017
Merged
@jjhursey
Copy link
Member

jjhursey commented Jun 2, 2017

This looks ok to me. @dsolt What do you think?

dsolt
dsolt approved these changes Jun 2, 2017
View reviewed changes
Copy link

@dsolt dsolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As discussed in the con call it will be nice if someday the packing utility will use a system independent format like XDR, but nothing about the API prevents us from doing that at a later time.

@rhc54 rhc54 added APPROVED and removed SUBMITTED labels Jun 2, 2017
Approved
f9cdbfd 
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
@rhc54 rhc54 merged commit 562f825 into pmix:master Jun 2, 2017
@rhc54 rhc54 deleted the topic/rfc0020 branch June 2, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsolt dsolt dsolt approved these changes

Assignees

@rhc54 rhc54

Labels
APPROVED Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhc54 @jjhursey @dsolt