Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romio: fix weak symbol blocks for large count functions #5310

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

hzhou
Copy link
Contributor

@hzhou hzhou commented May 29, 2021

Pull Request Description

The weak symbol block has to be placed before inclusion of mpioprof.h.

The fixes the clang build errors introduced by #5278

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@hzhou
Copy link
Contributor Author

hzhou commented May 29, 2021

test:mpich/ch3/tcp
compiler: clang

@hzhou
Copy link
Contributor Author

hzhou commented May 29, 2021

test:mpich/ch3/tcp
compiler:clang

image
Solaris doesn't have clang configured.

@hzhou
Copy link
Contributor Author

hzhou commented May 29, 2021

test:mpich/ch4/most
test:mpich/ch3/most

@hzhou hzhou requested a review from raffenet June 1, 2021 20:22
The weak symbol block has to be placed before inclusion of mpioprof.h.
@hzhou hzhou merged commit 274ce73 into pmodels:main Jun 2, 2021
@hzhou hzhou deleted the 2105_romio_fix branch June 2, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants