Add support for custom decoding/encoding to fileStorage
#3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a recent need to do some cache validation before retrieving the value (drop the file if it was created before some date). I wonder if instead of just focusing on codable this should go as far for loading/writing from/to URL. I'd love to ear about how to make a composable wrapper to handle caching too |
|
@oskarek Thanks for taking the time to PR! We do think that supporting more than JSON is a good idea but haven't had time to review yet and think about the API. Hopefully soon! |
stephencelis
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the
fileStoragepersistence key so that it can be used with values that are notCodable, by adding the ability to provide custom decode/encode closures as parameters. Also, forCodablevalues, the json decoder/encoder can now be customized.