Methods generateBatchProof and generateProof return the wrong type

[en]

• I'm submitting a ...

• Bug report
• Feature request
• Support request
• Other

• What is the current behavior and expected behavior?

api/packages/rpc-augment/src/augment/jsonrpc.ts

Lines 378 to 382 in 41d6429

	generateBatchProof: AugmentedRpc<(leafIndices: Vec<u64> | (u64 | AnyNumber | Uint8Array)[], at?: BlockHash | string | Uint8Array) => Observable<MmrLeafProof>>;
	/**
	* Generate MMR proof for given leaf index.
	**/
	generateProof: AugmentedRpc<(leafIndex: u64 | AnyNumber | Uint8Array, at?: BlockHash | string | Uint8Array) => Observable<MmrLeafBatchProof>>;

generateBatchProof and generateProof incorrectly use each other's return values.

• What is the motivation for changing the behavior?

Swap the type of the return value.

• Please tell us about your environment:

• Version: master

• Environment:

  • Node.js
  • Browser
  • Other (limited support for other environments)

• Language:

  • JavaScript
  • TypeScript (include tsc --version)
  • Other

[jacogr]

The issue is that RPCs are completely unversioned.

So in these cases your best approach is actually to submit a PR. (These is actually one open to align with latest Substrate master, see #5479)

In retrospect, the mmr RPCs should not have been added at all - since it changes the whole time at this point and seems very unstable. Changing return types would mean that it would be broken on some older versions and working on newer versions - which is the reverse of what we have.

So while we have "adjust-to-latest PRs", the best approach is actually just a complete removal until these are stabilized instead of playing whack-a-mole with unversioned changing RPCs.

[jacogr]

This is actually a duplicate as well, see #5478

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.