-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update MMR API #5479
update MMR API #5479
Conversation
4391d31
to
fa3e5df
Compare
ccea7af
to
a5c2b51
Compare
I've tested the API methods here: https://github.com/Lederstrumpf/polkadot-js-api-ts-template/blob/test-mmr-rpc/src/index.ts I'm also fine to remove the |
use latest MMR RPC API
a5c2b51
to
ef96d1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate all the effort here: thank you.
Could you please just merge in master, GH shows some conflicts.
the signature's changed in v2 for all runtime calls that they share.
gladly!
Done. As a followup to the merge, I've fully decoupled the MMR runtime methods wrt versioning in ff99764 (previously |
It is quite possible I mucked up something when adding the MMR V1/V2 split. Was also not quite comfortable with it anyway since it seemed that methods were added and then the version was only bumped afterwards - this could quite possibly just be the update schedule followed when these were adjusted. Anyway, I'm much happier when it comes "from the source of knowledge" on these since the intent is much clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small linting fixes suggested (as per CI failures) - there is however still an ordering issue, couldn't do that is the GH interface without mucking up.
Indeed - I post-bumped the versions here paritytech/substrate#13509 after your comment regarding this (#5479 (comment)). I acknowledge this compromise unfortunately leaves us with the inconsistency that nodes after ~v0.9.31 (iirc, the release where the first of these new/changed methods were introduced) but prior to v0.9.40 (where the version bump occurred) will report their API as being V1. Not bumping the API version would have avoided that, but begotten issues for earlier releases, hence the compromise.
Should be fixed now, if you rerun the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
(Will be included in the next release over the weekend)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #5478