Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colour pathological/non pathological mutants differntly #2249

Open
ValWood opened this issue Oct 1, 2024 · 36 comments
Open

colour pathological/non pathological mutants differntly #2249

ValWood opened this issue Oct 1, 2024 · 36 comments
Assignees

Comments

@ValWood
Copy link
Member

ValWood commented Oct 1, 2024

I think it would be really useful if we coloured the pathological single amino acid mutants differently from the non pathological.

I.e if a single amino acid mutant is either
abnormal or inviable phenotype colour them red
if viable or normal colour them grey
(some may have both abnormal and normal phenotypes, in these cases abnormal would trump.

Rationale.
I though of this when reviewing the InterPro website changes. They report/dispaly only pathogenic mutants (which is what most users will be interested. in).
We are unusual in that we also report non-pathological.
We report the non-pathological for information and completion, but it would be great if, when looking at this view you could see clearly which residues were the most important ones.

@ValWood ValWood changed the title colour pathogeneic/non pathogenic mutants differntly colour pathological/non pathological mutants differntly Oct 1, 2024
@kimrutherford
Copy link
Member

I think it would be really useful if we coloured the pathological single amino acid mutants differently from the non pathological.

That should be no problem and it will make the display look more interesting. What's the rationale for only colouring the single amino acid mutants?
For cdc15 most of the mutants are multi-locus:
https://www.pombase.org/gene_protein_features/SPAC20G8.05c

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

We could do both. I was biased toward point mutations because I was thinking about survivorship bias and this image:

Screenshot 2024-10-02 at 07 17 58

@kimrutherford
Copy link
Member

abnormal or inviable phenotype colour them red
if viable or normal colour them grey

Should this term be red or grey? It's viable but abnormal?

viable vegetative cell with abnormal cell shape (FYPO:0002197)

https://www.pombase.org/term/FYPO:0002197

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

This has some aspect of pathology so this would be red.

@kimrutherford
Copy link
Member

abnormal or inviable phenotype colour them red
if viable or normal colour them grey

So when should an allele be grey? Only when it's viable and also normal?

Are these the terms we need?:

id: FYPO:0000124
name: viable cell
id: FYPO:0000257
name: normal phenotype

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

If it is inviable (Cell or population) OR abnormal it should be red.

All others should be grey. So they would be grey if they have ONLY viable (cell or population) OR normal

@kimrutherford
Copy link
Member

If it is inviable (Cell or population) OR abnormal it should be red.

So inviable cell (FYPO:0000049) or inviable cell population (FYPO:0002059) or abnormal phenotype (FYPO:0001985)?

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

red if
inviable cell population (FYPO:0002059) or any of its descendants
inviable cell (FYPO:0000049) or any of itsdescendants
"abnormal phenotype" (FYPO:0001985) or any of its descendants

all others grey

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

yes sorry posts crossed, i was looking them up and got side tracked

@kimrutherford
Copy link
Member

First attempt:

image

@kimrutherford
Copy link
Member

We can do the same for partial deletions if you think that's useful:

image

@kimrutherford
Copy link
Member

An example with both:

image

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

This will be really useful!

Could you zoom in on this a bit?
The same alleles seem to. be present as both grey, and red?

Screenshot 2024-10-02 at 13 11 48

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

We can do the same for partial deletions if you think that's useful:

Yes, I think we should

@kimrutherford
Copy link
Member

Could you zoom in on this a bit?
The same alleles seem to. be present as both grey, and red?

It's here if you want for have a look:
https://desktop.kmr.nz/gene_protein_features/SPAC694.06c

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

Yep, I just looked:

So this one
Screenshot 2024-10-02 at 13 15 17

is the same allele separating normal and abnormal phenotypes.

I envisaged that we would represent each allele once but colour it red even if it had some normal phenotypes, and long as it had some abnormal phenotypes.

The rationale is that every allele will have lots of normal things, depending on what is tested. This is just a way to focus people attention on the alleles that have at least some identified detrimental effects.
However, now I don't know which option is best.

@PCarme what do you think?

@kimrutherford
Copy link
Member

They look different to me. Same positions but the substitutions are different (S572A vs S572C, etc.)

mrc1-SQ 	                S572A,S599A,S604A,S614A 	
mrc1-S572C,S599C,S604C,S614C 	S572C,S599C,S604C,S614C 	

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

doh, ignore me!

@kimrutherford
Copy link
Member

Are there any changes to make before I release this?

@ValWood
Copy link
Member Author

ValWood commented Oct 2, 2024

No go for it!

kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Oct 2, 2024
kimrutherford added a commit to pombase/pombase-python-web that referenced this issue Oct 2, 2024
@kimrutherford kimrutherford self-assigned this Oct 3, 2024
@kimrutherford
Copy link
Member

Those changes are on pombase.org now.

@ValWood
Copy link
Member Author

ValWood commented Oct 3, 2024

This is really useful.
I think we can improve it even more.
The grey normal are fine, but it would be good to see a separation between inviable and abnormal so
And we should maybe use the same colour scheme for both aa subs and partial deletion

perhaps
anything inviable >> anything abnormal > normal

And we should maybe use the same colour scheme for both aa subs and partial deletion
anything inviable (red) >> anything abnormal (pale pink?) > normal (grey)

@kimrutherford kimrutherford reopened this Oct 3, 2024
@kimrutherford
Copy link
Member

It was a challenge to find an example gene that has inviable, abnormal and normal alleles. Inviable is quite a lot less common than abnormal - I guess that makes sense.

I tried pale pink and it was difficult to see the difference between the inviable and the abnormal alleles. So here's how it looks with a more contrasting colour:

https://desktop.kmr.nz/gene_protein_features/SPAC23C4.18c

image

@PCarme
Copy link
Contributor

PCarme commented Oct 3, 2024

That's a good idea to distinguish between abnormal phenotypes and inviable, but I would have chosen an in-between color for abnormal. Orange maybe ?

@kimrutherford
Copy link
Member

Here's how it looks with orange:

image

@ValWood
Copy link
Member Author

ValWood commented Oct 3, 2024

I think Orange is a good plan. Can you use a stronger orange (as strong as you can go without it merging with the red)

Hex #F06631 

Hex #FD963D

Hex #FD5602

Hex #F5883F 

Hex #FF8000

Hex #E78400

Hex #FF6E00

Hex #FF6700 

Hex #FF9B00

Hex #FE5000 

Hex #FF6E4A 

Hex #FF7518

Hex #F76806

Hex #FF9916

Hex #FFA500

Hex #F96815

Hex #F05E23
Screenshot 2024-10-03 at 09 18 47

@ValWood
Copy link
Member Author

ValWood commented Oct 3, 2024

maybe most of these are too close to the red?

@ValWood
Copy link
Member Author

ValWood commented Oct 3, 2024

perhaps Hex #FF9B00 or Hex #FF9916

which red shade are we using ?

@ValWood
Copy link
Member Author

ValWood commented Oct 3, 2024

which red shade are we using ?

I was wondering if we could 'up the contrast' by moving the red shade towards one which is very slightly pink...we can try that once we have a stronger orange which works well.

@kimrutherford
Copy link
Member

The contrast varies between monitors so perhaps we can try a few options live on the next Zoom call.

Whatever colours we decide on I think it's good to make the inviable alleles clear because they are the uncommon case. Point mutations are the trickiest case. For example:
https://desktop.kmr.nz/gene_protein_features/SPBC25H2.13c
https://desktop.kmr.nz/gene_protein_features/SPAC20G8.01
https://desktop.kmr.nz/gene_protein_features/SPAC4A8.12c

@ValWood
Copy link
Member Author

ValWood commented Oct 3, 2024

OK, we can do that, there's no hurry.

@kimrutherford
Copy link
Member

which red shade are we using ?

It's #f00 in the configuration but the feature viewer code changes that to #ff7f7e for the interior of the features and #fceeed for the border. So it's difficult to directly set feature colours. There's a bit of trail and error.

@kimrutherford
Copy link
Member

#fceeed for the border.

Sorry, I got that wrong. We configure #f00 (also known as #ff0000) and that's what gets used for the border. The interior is a paler version of that colour: #ff7f7e.

kimrutherford added a commit to pombase/pombase-python-web that referenced this issue Oct 8, 2024
Also tweak the modification colours to be less green.

Refs pombase/website#2249
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Oct 8, 2024
@kimrutherford
Copy link
Member

I've committed those changes so it should be on pombase.org on Wednesday morning.
This is a page to check: https://www.pombase.org/gene_protein_features/SPBC2F12.08c

@kimrutherford
Copy link
Member

I forgot to update documentation for the modification colours here: https://www.pombase.org/documentation/gene-page-protein-features-widget

@kimrutherford kimrutherford reopened this Oct 9, 2024
kimrutherford added a commit that referenced this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants