Skip to content

Commit

Permalink
Lowercase branches when constructing an image identifier
Browse files Browse the repository at this point in the history
Executing a pull request test from a branch with upper case letters
ended up with this error:

        Command '/var/ARTIFACTS/work-behave-createrepo_crye9wxe5/plans/integration/behave-createrepo_c/tree/tmt-prepare-wrapper.sh-Build-testing-container-default-0' returned 1.

        stderr (2 lines)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        Error: tag container-test-unistd-for-STDOUT_FILENO-master: invalid reference format: repository name must be lowercase
        Error: Failed to build the container.
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The cause was that -c argument of container-test script was built from
a "container-test-unistd-for-STDOUT_FILENO" branch name. The
container-test -c value is then directly passed as an image identifier
to podman build and podman run commands. Problem is that podman, as
well as docker, does not allow upper-case characters in the OCI
identifier.

I wanted to circumvent it in the container-test script, to have a fix
at one place. But one can pass a tag name there (foo/bar:tag) and the
tag is handled case sensitively by docker.

So this patch fixes it on the invocation side.

NOTE: I could not really test it. I only tried a prepare phase of
locally run TMT and it correctly transliterated the branch names. You
should be able to fix by rerunning tests for
<rpm-software-management/createrepo_c#439>.
  • Loading branch information
ppisar committed Oct 7, 2024
1 parent e7f23f3 commit 89e55d2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion plans/integration/behave-createrepo_c.fmf
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ execute:
script: |
$TMT_PLANS_DATA/ci-dnf-stack/container-test \
--suite createrepo_c \
-c container-test-$PACKIT_SOURCE_BRANCH-$PACKIT_TARGET_BRANCH run
-c container-test-${PACKIT_SOURCE_BRANCH,,?}-${PACKIT_TARGET_BRANCH,,?} run
2 changes: 1 addition & 1 deletion plans/integration/behave-dnf.fmf
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ execute:
how: tmt
script: |
$TMT_PLANS_DATA/ci-dnf-stack/container-test \
-c container-test-$PACKIT_SOURCE_BRANCH-$PACKIT_TARGET_BRANCH run
-c container-test-${PACKIT_SOURCE_BRANCH,,?}-${PACKIT_TARGET_BRANCH,,?} run

2 changes: 1 addition & 1 deletion plans/main.fmf
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ prepare:
how: shell
script: |
$TMT_PLANS_DATA/ci-dnf-stack/container-test \
-c container-test-$PACKIT_SOURCE_BRANCH-$PACKIT_TARGET_BRANCH build \
-c container-test-${PACKIT_SOURCE_BRANCH,,?}-${PACKIT_TARGET_BRANCH,,?} build \
--base $( echo "$@distro" | tr '-' ':') \
--container-arg="--env=COPR=$PACKIT_COPR_PROJECT" \
--container-arg="--env=COPR_RPMS=$PACKIT_COPR_RPMS"

0 comments on commit 89e55d2

Please sign in to comment.