-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click on Checkbox Fires Twice #358
Comments
I'd need to know roughly what I think you might be right though - it seems like the above linked normalization never removes the old |
Should I move the issue to preact-compat? In my app, when you click on a checkbox, a redux action is dispatched, which causes the state of the app to be changed, thus setting the checked prop of my Checkbox component. |
Perfect, sounds like we just need to have preact-compat delete the |
Glad to help, keep up the good work! |
This should prevent the change event to firing twice when clicking on a checkbox, see here: preactjs/preact#358
This should prevent the change event from firing twice when clicking on a checkbox, see here: preactjs/preact#358
This should prevent the change event from firing twice when clicking on a checkbox, see here: preactjs/preact#358
This has been fixed in |
I have a checkbox with an onchange handler like this:
When I click the checkbox, nothing happens. I think this is because the click triggers both a click and onchange event, one ticks the checkbox, the other unchecks it again (using Redux to handle the event).
I'm using Preact 6.3.0 with Preact-Compat 3.7.1.
Is this a bug, or do I have to change my implementation when using Preact instead of React? It works without a problem with Facebook's React.
The text was updated successfully, but these errors were encountered: