Skip to content

Commit

Permalink
Revert "fix: creating a new chart with dashboard time filters but fil…
Browse files Browse the repository at this point in the history
…ter can't apply again (apache#24405)"

This reverts commit 6dba6e3.
  • Loading branch information
jinghua-qa committed Jun 22, 2023
1 parent f375265 commit 877bd82
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions superset-frontend/src/explore/actions/saveModalActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,6 @@ export const getSlicePayload = (
adhocFilters = extractAddHocFiltersFromFormData(formDataFromSlice);
}

if (
isEmpty(adhocFilters?.adhoc_filters) &&
isEmpty(formDataFromSlice) &&
formDataWithNativeFilters?.adhoc_filters?.length > 0
) {
adhocFilters.adhoc_filters = [
{
...formDataWithNativeFilters.adhoc_filters[0],
comparator: 'No filter',
},
];
}

const formData = {
...formDataWithNativeFilters,
...adhocFilters,
Expand Down

0 comments on commit 877bd82

Please sign in to comment.