Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build System Rewrite] Improved audio rules #1957

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

Icedude907
Copy link
Contributor

No dependencies

Description

  • Coalesced songs and samples into one audio_rules.mk file
  • A special file midi.cfg has been created which contains the commands for mid2agb. Replaces songs.mk. audio_rules expands the file into make rules.

Discord contact info

icedude907

Copy link
Member

@GriffinRichards GriffinRichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me (+ the missing newlines). One note is that it might be better to have midi.cfg in sound? By default it's alphabetically at the top in sound/songs/midi, but it's easy to miss in there.

endef
# source path, remaining text (options)
define MID_EXPANSION
$(eval $(call MID_RULE,$(basename $(patsubst %:,%,$(word 1,$1))),$(wordlist 2,999,$1)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity it might be worth pointing out that the 999 is an arbitrarily long end point. Not necessary, just raised an eyebrow at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants