ignore browserslist warnings (#1494)

priceline · May 30, 2024 · c4129de · c4129de
1 parent 206c29c
commit c4129de
Show file tree

Hide file tree

Showing 17 changed files with 760 additions and 225 deletions.
diff --git a/.github/workflows/chromatic-ci.yaml b/.github/workflows/chromatic-ci.yaml
@@ -3,6 +3,9 @@ name: Chromatic CI
 on:
   push:
 
+env:
+  BROWSERSLIST_IGNORE_OLD_DATA: 1
+
 jobs:
   chromatic-ci:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -4,6 +4,9 @@ on:
   push:
   workflow_dispatch:
 
+env:
+  BROWSERSLIST_IGNORE_OLD_DATA: 1
+
 jobs:
   design-system-ci:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/npm-publish-beta.yaml b/.github/workflows/npm-publish-beta.yaml
@@ -7,6 +7,9 @@ on:
         required: true
         description: Tag to append to version of each package
 
+env:
+  BROWSERSLIST_IGNORE_OLD_DATA: 1
+
 jobs:
   # Set the job key. The key is displayed as the job name
   # when a job name is not provided

diff --git a/.github/workflows/npm-publish.yaml b/.github/workflows/npm-publish.yaml
@@ -2,6 +2,9 @@ name: Rush publish to NPM
 
 on: workflow_dispatch
 
+env:
+  BROWSERSLIST_IGNORE_OLD_DATA: 1
+
 jobs:
   # Set the job key. The key is displayed as the job name
   # when a job name is not provided

diff --git a/.github/workflows/on-main.yml b/.github/workflows/on-main.yml
@@ -1,5 +1,8 @@
 name: On Main Merge - Build Storybook
 
+env:
+  BROWSERSLIST_IGNORE_OLD_DATA: 1
+
 on:
   push:
     branches: [main]

diff --git a/.github/workflows/release-branch.yaml b/.github/workflows/release-branch.yaml
@@ -1,5 +1,8 @@
 name: Create a new GitHub release for a package
 
+env:
+  BROWSERSLIST_IGNORE_OLD_DATA: 1
+
 on:
   workflow_dispatch:
     inputs:

diff --git a/apps/storybook/.storybook/main.ts b/apps/storybook/.storybook/main.ts
@@ -1,4 +1,6 @@
 import type { StorybookConfig } from '@storybook/react-vite'
+import turbosnap from 'vite-plugin-turbosnap'
+import { mergeConfig } from 'vite'
 
 const packagesWithStories = [
   'carousel',
@@ -32,6 +34,19 @@ const config: StorybookConfig = {
   typescript: {
     check: false,
   },
+  async viteFinal(config, { configType }) {
+    return mergeConfig(config, {
+      plugins:
+        configType === 'PRODUCTION'
+          ? [
+              turbosnap({
+                // This should be the base path of your storybook.  In monorepos, you may only need process.cwd().
+                rootDir: config.root ?? process.cwd(),
+              }),
+            ]
+          : [],
+    })
+  },
 }
 
 export default config
diff --git a/apps/storybook/package.json b/apps/storybook/package.json
@@ -22,35 +22,37 @@
     "@babel/core": "^7.23.5",
     "@priceline/eslint-config": "workspace:*",
     "@rushstack/eslint-patch": "^1.6.0",
-    "@storybook/addon-a11y": "^7.6.4",
-    "@storybook/addon-actions": "^7.6.4",
-    "@storybook/addon-coverage": "^1.0.0",
-    "@storybook/addon-designs": "^7.0.7",
-    "@storybook/addon-docs": "^7.6.4",
-    "@storybook/addon-essentials": "^7.6.4",
-    "@storybook/addon-interactions": "^7.6.4",
-    "@storybook/addon-viewport": "^7.6.4",
-    "@storybook/addons": "^7.6.4",
-    "@storybook/components": "^7.6.4",
+    "@storybook/addon-a11y": "^7.6.19",
+    "@storybook/addon-actions": "^7.6.19",
+    "@storybook/addon-coverage": "^1.0.4",
+    "@storybook/addon-designs": "^7.0.9",
+    "@storybook/addon-docs": "^7.6.19",
+    "@storybook/addon-essentials": "^7.6.19",
+    "@storybook/addon-interactions": "^7.6.19",
+    "@storybook/addon-viewport": "^7.6.19",
+    "@storybook/addons": "^7.6.17",
+    "@storybook/components": "^7.6.19",
     "@storybook/jest": "^0.2.3",
-    "@storybook/manager-api": "^7.6.4",
-    "@storybook/preview-api": "^7.6.4",
-    "@storybook/react": "^7.6.4",
-    "@storybook/react-vite": "^7.6.4",
+    "@storybook/manager-api": "^7.6.19",
+    "@storybook/preview-api": "^7.6.19",
+    "@storybook/react": "^7.6.19",
+    "@storybook/react-vite": "^7.6.19",
     "@storybook/testing-library": "^0.2.2",
-    "@storybook/theming": "^7.6.4",
+    "@storybook/theming": "^7.6.19",
     "babel-plugin-react-docgen": "^4.2.1",
-    "chromatic": "^10.1.0",
+    "chromatic": "^10.9.6",
+    "core-js": "^3.37.1",
     "eslint": "^8.55.0",
     "npm-run-all": "^4.1.5",
     "pcln-design-system": "workspace:*",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "react-is": "^18.2.0",
     "require-from-string": "2.0.2",
-    "storybook": "^7.6.4",
+    "storybook": "^7.6.19",
     "styled-components": "^5.3.11",
     "typescript": "^5.3.3",
-    "vite": "^4.5.1"
+    "vite": "^4.5.3",
+    "vite-plugin-turbosnap": "^1.0.3"
   }
 }
diff --git a/common/changes/pcln-icons/ignore-browserslist-warnings_2024-05-28-17-45.json b/common/changes/pcln-icons/ignore-browserslist-warnings_2024-05-28-17-45.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "pcln-icons",
+      "comment": "that silly line break",
+      "type": "none"
+    }
+  ],
+  "packageName": "pcln-icons"
+}
diff --git a/common/changes/pcln-menu/ignore-browserslist-warnings_2024-05-30-18-01.json b/common/changes/pcln-menu/ignore-browserslist-warnings_2024-05-30-18-01.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "pcln-menu",
+      "comment": "add core-js dev depedency to fix storybook",
+      "type": "patch"
+    }
+  ],
+  "packageName": "pcln-menu"
+}
diff --git a/common/changes/pcln-popover/ignore-browserslist-warnings_2024-05-30-18-01.json b/common/changes/pcln-popover/ignore-browserslist-warnings_2024-05-30-18-01.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "pcln-popover",
+      "comment": "add core-js dev dep to fix storybook",
+      "type": "patch"
+    }
+  ],
+  "packageName": "pcln-popover"
+}
diff --git a/common/config/rush/pnpm-config.json b/common/config/rush/pnpm-config.json
@@ -88,7 +88,9 @@
    *
    * PNPM documentation: https://pnpm.io/package_json#pnpmoverrides
    */
-  "globalOverrides": {
+   "globalOverrides": {
+    "browserslist": "latest",
+    "caniuse-lite": "latest"
     // "example1": "^1.0.0",
     // "example2": "npm:@company/example2@^1.0.0"
   },