Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: upgrade to styled-components v6 #1482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sdalonzo
Copy link
Collaborator

No description provided.

@@ -93,24 +93,24 @@
{Boolean(Icon) && <Icon title={IconTitle} size='20px' />}
<Box>
{Boolean(topLabel) && (
<Text regular ml={2} mb={1} fontWeight='bold'>
<Text fontWeight='regular' ml={2} mb={1} fontWeight='bold'>

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'fontWeight' is useless, since
another property write
always overrides it.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. batch replace.

@sdalonzo sdalonzo force-pushed the styled-components-v6 branch 2 times, most recently from 7bf61f4 to 8930ba6 Compare April 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant