Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix foreign derive proc macro attributes clashing with Veil's #40

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Fix foreign derive proc macro attributes clashing with Veil's #40

merged 4 commits into from
Oct 19, 2022

Conversation

WilliamVenner
Copy link
Contributor

Spotted this issue in the wild

@WilliamVenner WilliamVenner requested a review from a team October 19, 2022 10:14
@cpiemontese cpiemontese requested a review from Fs00 October 19, 2022 10:40
MaeIsBad
MaeIsBad approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamVenner WilliamVenner merged commit 1fc61d6 into master Oct 19, 2022
@WilliamVenner WilliamVenner deleted the fix-foreign-attributes branch October 19, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaeIsBad MaeIsBad MaeIsBad approved these changes

@Fs00 Fs00 Awaiting requested review from Fs00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamVenner @MaeIsBad