[PLATFORM-860]: Veil memory optimisations and refactoring #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaeIsBad
reviewed
Dec 15, 2022
Co-authored-by: MaeIsBad <26093674+MaeIsBad@users.noreply.github.com>
MaeIsBad
reviewed
Dec 15, 2022
MaeIsBad
reviewed
Dec 15, 2022
| Partial, | ||
|
|
||
| /// Whether to redact with a fixed width, ignoring the length of the data. | ||
| Fixed(NonZeroU8), |
There was a problem hiding this comment.
any reason to keep this as just an u8 instead of u32 or usize?
There was a problem hiding this comment.
I don't think anyone is gonna need anything greater than 255 characters :V
|
Can this be merged @WilliamVenner @MaeIsBad? |
|
Yes I think it's ok :) just need approve |
cpiemontese
approved these changes
Dec 16, 2022
WilliamVenner
deleted the
PLATFORM-860/user-story/veil-memory-optimisations-and-refactoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-860
Veil has a large opportunity to optimise memory usage by writing directly to the
std::fmt::Formatter, this should have been done from the start really.I've also used this opportunity to refactor internal Veil code, as it was getting a bit messy and unclear.