[PLATFORM-865]: Add a builder type for redaction to Veil, for manually redacting arbitrary data #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamVenner
force-pushed
the
PLATFORM-865/user-story/add-a-builder-type-for-redaction-to-veil-for-manually-redacting-arbitrary-data
branch
from
b4108e6
to
fffffb7
Compare
MaeIsBad
reviewed
Dec 19, 2022
WilliamVenner
force-pushed
the
PLATFORM-865/user-story/add-a-builder-type-for-redaction-to-veil-for-manually-redacting-arbitrary-data
branch
from
fffffb7
to
3321d93
Compare
MaeIsBad
reviewed
Dec 20, 2022
MaeIsBad
previously approved these changes
Dec 20, 2022
…dacting arbitrary data
WilliamVenner
force-pushed
the
PLATFORM-865/user-story/add-a-builder-type-for-redaction-to-veil-for-manually-redacting-arbitrary-data
branch
from
9dc2a91
to
76abc3b
Compare
MaeIsBad
approved these changes
Dec 20, 2022
WilliamVenner
deleted the
PLATFORM-865/user-story/add-a-builder-type-for-redaction-to-veil-for-manually-redacting-arbitrary-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-865
This PR introduces the
Redactor,RedactorBuilderandRedactWrappedtypes.The
RedactorBuilderallows for building aRedactorusing familiar flags seen in the#[redact]derive macro. The builtRedactormay then be used to redact any arbitrary data using the flags provided.The
RedactorBuilderhas been set up for 100% const evaluation, therefore the compiler is able to completely eliminate any error checking at compile time. The error checking is zero cost if everything is known at compile time :DFinally I have also used the
RedactWrappedtype as a convenience API. It is returned by thewrapmethod ofRedactor. I have documented this with examples, and plan to document everything on a higher level (e.g. in examples/ and the crate root docs) in a separate PR.