[PLATFORM-866]: Update examples and documentation in Veil for all the new changes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaeIsBad
reviewed
Dec 19, 2022
MaeIsBad
reviewed
Dec 19, 2022
WilliamVenner
force-pushed
the
PLATFORM-866/user-story/update-examples-and-documentation-in-veil-for-all-the-new-changes
branch
from
b85a3de
to
de9b57e
Compare
|
Looks like the Dronefile was formatted by my IDE. I didn't even know you could format a YAML file incorrectly. Oh well |
|
I think you can completely remove the signature section of the drone file by the way |
|
Yeah it needs to be resigned now. I think we should do that in this PR. Are we able to self-sign them now, or do we need to ask someone? |
|
Oh right, I thought drone just let the CI through on veil. I think only @cpiemontese should be able to sign it, but for whatever reason drone also lets me do it, so 🤷♀️ |
MaeIsBad
reviewed
Dec 22, 2022
MaeIsBad
reviewed
Dec 22, 2022
MaeIsBad
previously approved these changes
Dec 22, 2022
Co-authored-by: MaeIsBad <26093674+MaeIsBad@users.noreply.github.com>
|
Ok then... not sure why it dismissed the review when it was a committed suggestion. |
MaeIsBad
approved these changes
Dec 22, 2022
WilliamVenner
deleted the
PLATFORM-866/user-story/update-examples-and-documentation-in-veil-for-all-the-new-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-866
Docs & examples for all the new stuff.