Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel target arrow points to the wrong position when target is on the right edge of the screen #10484

Closed
thsoliveira opened this issue Aug 6, 2021 · 5 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@thsoliveira
Copy link

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/angular-ivy-1asash

Current behavior
I'm having the same problem with the overlaypanel when it's called in the right edge of the screen the arrow shows out of the panel box. I don't know if it's an issue of my project or if it's a primeng thing because of the arrow position calculation it seems weird. This only happens when the overlaypanel is called on the right side of the screen, if I change the position of the element that calls the overlaypanel everything works just fine.

image

Expected behavior
Should open the overlaypanel with the arrow above the box

Minimal reproduction of the problem with instructions

  1. Click on the button to open the overlaypanel

https://stackblitz.com/edit/angular-ivy-1asash

What is the motivation / use case for changing the behavior?
When the overlay panel is called on the edge of the right side of the screen the arrow is misplaced

Please tell us about your environment:

  • Angular version: 5.X
    12.2.0

  • PrimeNG version: 5.X
    12.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all

  • Node (for AoT issues): node --version =
    all

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 13, 2021
@bgl3317
Copy link

bgl3317 commented Oct 29, 2021

I'm having the same issue in v11.

@moussa-b
Copy link

I would add also that the close icon is wrongly placed

image

@kunjan343
Copy link

Any progress? Hate to say PrimeNG library is not designed properly.

gucal added a commit that referenced this issue Nov 2, 2022
@gucal gucal linked a pull request Nov 2, 2022 that will close this issue
@cetincakiroglu cetincakiroglu added this to the 14.2.0 milestone Nov 2, 2022
@gucal gucal removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 2, 2022
@mertsincan mertsincan modified the milestones: 14.2.0, 14.2.1 Nov 8, 2022
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@mertsincan mertsincan removed this from the 14.2.2 milestone Nov 9, 2022
@cetincakiroglu cetincakiroglu added this to the 15.0.1 milestone Dec 29, 2022
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Dec 29, 2022
@cetincakiroglu cetincakiroglu removed this from the 15.0.1 milestone Dec 29, 2022
@cetincakiroglu cetincakiroglu reopened this Mar 9, 2023
@cetincakiroglu cetincakiroglu added this to the 15.2.1 milestone Mar 9, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 9, 2023
cetincakiroglu added a commit that referenced this issue Mar 9, 2023
… when target is on the right edge of the screen
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 9, 2023
@cetincakiroglu
Copy link
Contributor

fixed in f9f7e47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants