Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoComplete: completeOnFocus #13344

Closed
arunvc opened this issue Jul 19, 2023 · 1 comment · Fixed by #13350
Closed

AutoComplete: completeOnFocus #13344

arunvc opened this issue Jul 19, 2023 · 1 comment · Fixed by #13350
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.3.0

Comments

@arunvc
Copy link

arunvc commented Jul 19, 2023

Describe the bug

when a selection is made then multiple api calls are made when we click on the autocomplete dropdown button with completeOnFocus=true,

sample.webm 
    <p-autoComplete [(ngModel)]="selectedCountry" [dropdown]="true" [suggestions]="filteredCountries" (completeMethod)="filterCountry($event)" field="name"
    [completeOnFocus]="true"
    ></p-autoComplete>

Environment

Ubuntu 22.04

Reproducer

https://stackblitz.com/edit/pyscce?file=src%2Fapp%2Fdemo%2Fautocomplete-dropdown-demo.html

Angular version

16

PrimeNG version

16

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16

Browser(s)

Firefox

Steps to reproduce the behavior

check the attached video

Expected behavior

No response
@arunvc arunvc added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 19, 2023
SoyDiego added a commit to SoyDiego/primeng that referenced this issue Jul 19, 2023
@SoyDiego
[primefaces#13344] - Fixed double call autocomplete component
e3b11ee
@SoyDiego SoyDiego mentioned this issue Jul 19, 2023
Merged
@SoyDiego
Copy link
Contributor

Hi @arunvc I have checked the problem and I did PR. You can check here #13350
Now we should wait if PrimeNG Team approve it.

mertsincan pushed a commit that referenced this issue Aug 29, 2023
@SoyDiego
[#13344] - Fixed double call autocomplete component (#13350)
cbf0de3
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 29, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.3.0
Development

Successfully merging a pull request may close this issue.

[#13344] - Fixed double call autocomplete component SoyDiego/primeng
3 participants
@arunvc @mertsincan @SoyDiego