Fixed #13910 - Menu Templating

[gucal]

fixed #13910

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
primeng-ssr-test	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2023 1:27pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2023 1:27pm

[Michael-Ziluck]

This breaks all existing usage of the template for tab menus. Previously We only needed to do the following:

<p-tabMenu [(activeItem)]="currentTab" [model]="tabItems">
  <ng-template pTemplate="item" let-item>
    {{ item.label | translate: I18N_PRODUCT }}
  </ng-template>
</p-tabMenu>

Which would result in this display:

Now with the same markup, it results in this:

The change is because previously, the <ng-container> was within the <a> tag. I know you updated the docs to reflect this, but shouldn't breaking changes be constrained to major version changes? Seems wildly arbitrary and inconvenient for users to have to make the change. I'll be opening a bug issue as well.