Fixed #15779 - Closing nested dialog removes CSS class still needed f… #15845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or parent dialog
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes. |
SoyDiego
reviewed
Jun 14, 2024
| @@ -266,6 +267,13 @@ export class DynamicDialogComponent implements AfterViewInit, OnDestroy { | |||
| return this.config?.templates?.closeicon; | |||
| } | |||
|
|
|||
| get dynamicDialogCount() { | |||
| let dynamicDialogs = this.document.querySelectorAll('p-dynamicdialog'); | |||
There was a problem hiding this comment.
You can use const instead of let because the variables will not be reasigned
SoyDiego
approved these changes
Jun 14, 2024
|
Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15779