Button: only add fallback aria-labelledby if aria-label isn't present

[siddharthkp]

• Found this bug in Add loading prop for Button and IconButton #3582 in integration tests for release candidate: https://github.com/github/github/pulls?q=is:pr+is:open+head:primer/react-integration

Changelog

In #3582, we introduced an aria-labelledby for all instances of Button. This however isn't a good idea when aria-label is already present on the instance.

aria-labelledby takes precedence over aria-label, so we only want to add a fallback aria-labelledby when aria-label isn't present

Skipping changeset because this is a bug fix for an unreleased PR

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Tested with gh/gh by making the changes locally

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

⚠️ No Changeset found

Latest commit: e6f8aef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	88.96 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js	89.25 KB (-0.01% 🔽)

[langermank]

Thank you!

[pksjce]

wow TIL about the precedence

[siddharthkp]

Sorry, this wasn't enough. There are more CI failures, Need to revert #3582 :(

Reverted in #4464