Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeView: Add custom aria label to TreeView.Item #4617

Merged
merged 3 commits into from
May 29, 2024
Merged

TreeView: Add custom aria label to TreeView.Item #4617

merged 3 commits into from
May 29, 2024

Conversation

JelloBagel
Copy link
Contributor

Changelog

New

Support aria-label and aria-labelledby in the TreeView.Item

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 32dc53f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.37 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 89.64 KB (-0.06% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4617 May 21, 2024 21:41 Inactive
@JelloBagel JelloBagel marked this pull request as ready for review May 21, 2024 22:01
@JelloBagel JelloBagel requested a review from a team as a code owner May 21, 2024 22:01
@JelloBagel JelloBagel requested a review from keithamus May 21, 2024 22:01
@JelloBagel
Copy link
Contributor Author

@primer/engineer-reviewers 👋 bumping this PR. Can I get a review?

broccolinisoup
broccolinisoup reviewed May 28, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one usage (internal link only) at dotcom that passes aria-label to TreeView.Item - just wanted to make sure we don't break any tests of this files with the change. Could we run integration tests at dotcom (internal link only)?

.changeset/hungry-rockets-smell.md Outdated Show resolved Hide resolved
@JelloBagel
Copy link
Contributor Author

@broccolinisoup CI checks are passing in dotcom 🙂

broccolinisoup
broccolinisoup approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JelloBagel JelloBagel added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 42ba5dc May 29, 2024
30 checks passed
@JelloBagel JelloBagel deleted the jellobagel-aria branch May 29, 2024 00:29
@primer primer bot mentioned this pull request May 29, 2024
Merged
khiga8 pushed a commit that referenced this pull request May 31, 2024
@JelloBagel @khiga8
TreeView: Add custom aria label to TreeView.Item (#4617)
e398336 
* Add custom aria label to TreeView.Item

* Add changelog

* Update hungry-rockets-smell.md
@JonathanXDR JonathanXDR mentioned this pull request Jun 21, 2024
Closed
@StemmlerSisters StemmlerSisters mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request Jul 17, 2024
Open
@Canadatechmanufacturing Canadatechmanufacturing mentioned this pull request Jul 17, 2024
Open
This was referenced Aug 2, 2024
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 16, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@keithamus keithamus Awaiting requested review from keithamus keithamus is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelloBagel @broccolinisoup