Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions, use 3.3.0-0 #16

Closed
wants to merge 6 commits into from

Conversation

piotr-yuxuan
Copy link

No description provided.

@rune-brinckmeyer
Copy link

Any plans/timeline wrt accept this pull-request?

@piotr-yuxuan
Copy link
Author

piotr-yuxuan commented May 3, 2018

@priornix Anything I can do to help the process of getting this merged?

@yanlobkarev
Copy link

...ping
Any updates?

@yanlobkarev
Copy link

@piotr-yuxuan
Firstly, must say thanks for You devotion and work!
Secondly, I tried out your master branch and had an issue with (ant/list):

Warning: React.createElement(...): Expected props argument to be a plain object. Properties defined in its prototype chain will be ignored. react.inc.js

for code:

  (:require [antizer.rum :as ant]
            [goog.dom :as gdom]
            [rum.core :as rum]
  ))

(enable-console-print!)

(rum/defc app < rum/static
  []
  (ant/list
    {:item-layout "horizontal"
    :grid {:gutter 16 :column 4}
    :data-source (repeat 4 {:title "title"})
    :render-item (fn [item]
                   (let [{:keys [title]} (js->clj item :keywordize-keys true)]
                     (ant/list-item
                       (ant/card {:title title}
                                 "Card content"))))
    }))

(rum/mount (app) (gdom/getElement "app"))

However everything had been displayed properly:

Should I open issue?

@piotr-yuxuan
Copy link
Author

I've just seen it. Let's see what I can do.

@priornix
Copy link
Owner

priornix commented Aug 1, 2018

@sctianwei @piotr-yuxuan Thanks for the help guys! I have pulled the changes and updated the library to use Ant 3.7.1.

@priornix
Copy link
Owner

priornix commented Aug 1, 2018

@yanlobkarev I have tested your example and it did not create any warnings with antd verison 3.7.1. and rum 0.11.2. Perhaps you should try upgrading antizer to 0.3.0 and rum to 0.11.2. Otherwise, please open a new ticket if you are still having problems.

@priornix
Copy link
Owner

@piotr-yuxuan Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants