Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Linted some parts of code #327

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nikhilponnuru
Copy link

used global directives to avoid warnings and errors shown by jshint and jslint
changed way of accessing object properties
used concept of javascript hoisting and declared variable -'messaging' before it is used [as it is the recommended practice ]

@irdan
Copy link
Member

irdan commented Feb 12, 2016

You will want to target the develop branch for most PR's. Some of these issues may have already been addressed there.

@nikhilponnuru
Copy link
Author

@irdan but these are being mentioned in code climate which is suggested by privly in documentation to follow for bug tracing
[ this I am saying because I thought code climate will be reflected with changes in code when merged ...am I wrong with this assumption ? ]

@smcgregor
Copy link
Member

Development targets the develop branch. CodeClimate doesn't let me change the default branch, for some reason.

@nikhilponnuru
Copy link
Author

@smcgregor hey should I focus on develop branch to contribute to this project and my pull request can't it be accepted ?

@smcgregor
Copy link
Member

Yes, all contributions should be made against the develop branch of the repository. If you are submitting this pull request with the purpose of completing the "levels" on our development guide, you can consider L0 to be completed. I won't be merging this pull request since the files have since changed.

@smcgregor
Copy link
Member

@nikhilponnuru If you want this PR to be accepted, you should close it and open a new one against the develop branch. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants