Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation field to param #42

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

DaymasS
Copy link
Contributor

@DaymasS DaymasS commented Jul 25, 2024

Изменения

Добавлена валидация данных в юзер дате и тесты к ней

Детали реализации

У таблицы Param появилось новое поле validation - строка - нулабл

При заполнении этой строки происходит проверка компилируемости полученного регулярного выражения. При ошибке возвращается код 422 Invalid Regex.

Далее при попытке обновить или создать параметр с не нулевым полем валидации у какого либо юзера будет происходить сравнение нового значения параметра с регулярным выражением. При ошибке возвращается код 422 Invalid Validation.

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@DaymasS DaymasS linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 25, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
userdata_api
   __main__.py17170%1–26
   exceptions.py19195%18
userdata_api/models
   base.py65592%25–28, 76
   db.py57198%88
userdata_api/routes
   category.py41490%38, 71–73
   exc_handlers.py20195%25
   param.py53885%39, 59, 98–101, 106, 129
   source.py30197%35
userdata_api/schemas
   base.py8450%6–9
   user.py24771%22–28
userdata_api/schemas/types
   scope.py24675%29–31, 36, 39, 41
userdata_api/utils
   user.py81298%81, 85
TOTAL5355789% 

Summary

Tests Skipped Failures Errors Time
57 0 💤 0 ❌ 0 🔥 3.086s ⏱️

@grigoriev-semyon grigoriev-semyon requested review from Temmmmmo and removed request for grigoriev-semyon July 30, 2024 17:33
@DaymasS DaymasS self-assigned this Jul 30, 2024
@DaymasS DaymasS removed the request for review from grigoriev-semyon July 31, 2024 05:48
userdata_api/routes/exc_handlers.py Outdated Show resolved Hide resolved
userdata_api/routes/exc_handlers.py Outdated Show resolved Hide resolved
userdata_api/utils/user.py Outdated Show resolved Hide resolved
userdata_api/utils/user.py Show resolved Hide resolved
userdata_api/utils/user.py Outdated Show resolved Hide resolved
@Temmmmmo Temmmmmo merged commit 5486b63 into main Aug 22, 2024
2 checks passed
@Temmmmmo Temmmmmo deleted the Add-validation-field-to-param branch August 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Валидация данных в юзердате
2 participants