Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SASL support to core. #213

Merged
merged 5 commits into from Sep 18, 2011
Merged

Add SASL support to core. #213

merged 5 commits into from Sep 18, 2011

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2011

It has been long awaited, and now it's finally done! I think I didn't forget anything; username is public, but password is private. I tested it on localhost.

So, briefly how it works:

  • If neither SASL username nor password are set, it just skips authentication.
  • If password is set but username isn't, a warning is given and authentication is skipped.
  • If both are set, it authenticates. I won't explain how SASL works here, look at the code. :)
  • If SASL is not supported, it will probably just silently fail at authenticating.

Fixed issue from pull request #211.

@progval
Copy link
Owner

progval commented Sep 13, 2011

Don't surround = by spaces in argument list.

@ghost
Copy link
Author

ghost commented Sep 14, 2011

@progval Fixed.

progval added a commit that referenced this pull request Sep 18, 2011
@progval progval merged commit e9697ff into progval:testing Sep 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant