Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar for time-based decisions #355

Merged
merged 1 commit into from
Dec 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ title: "Rule Index of Solhint"
| [no-complex-fallback](./rules/security/no-complex-fallback.md) | Fallback function must be simple. | ✔️ |
| [no-inline-assembly](./rules/security/no-inline-assembly.md) | Avoid to use inline assembly. It is acceptable only in rare cases. | ✔️ |
| [not-rely-on-block-hash](./rules/security/not-rely-on-block-hash.md) | Do not rely on "block.blockhash". Miners can influence its value. | ✔️ |
| [not-rely-on-time](./rules/security/not-rely-on-time.md) | Avoid to make time-based decisions in your business logic. | ✔️ |
| [not-rely-on-time](./rules/security/not-rely-on-time.md) | Avoid making time-based decisions in your business logic. | ✔️ |
| [reentrancy](./rules/security/reentrancy.md) | Possible reentrancy vulnerabilities. Avoid state changes after transfer. | ✔️ |
| [state-visibility](./rules/security/state-visibility.md) | Explicitly mark visibility of state. | ✔️ |

Expand Down
2 changes: 1 addition & 1 deletion docs/rules/security/not-rely-on-time.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ title: "not-rely-on-time | Solhint"


## Description
Avoid to make time-based decisions in your business logic.
Avoid making time-based decisions in your business logic.

## Options
This rule accepts a string option of rule severity. Must be one of "error", "warn", "off". Default to warn.
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/security/not-rely-on-time.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const meta = {
type: 'security',

docs: {
description: `Avoid to make time-based decisions in your business logic.`,
description: `Avoid making time-based decisions in your business logic.`,
category: 'Security Rules'
},

Expand Down Expand Up @@ -34,7 +34,7 @@ class NotRelyOnTimeChecker extends BaseChecker {
}

_warn(node) {
this.warn(node, 'Avoid to make time-based decisions in your business logic')
this.warn(node, 'Avoid making time-based decisions in your business logic')
}
}

Expand Down