Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directories with .sol in the name path treated as files #388

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

dbale-altoros
Copy link
Collaborator

This PR adds E2E tests for the pr #352
Credits to @pycckuu

@dbale-altoros dbale-altoros force-pushed the fix/dirs-with-sol-extension branch 2 times, most recently from d58e67f to 93b9607 Compare January 25, 2023 20:07
@dbale-altoros dbale-altoros changed the title fix: directories with .sol extension treated as files fix: directories with .sol in the name path treated as files Jan 25, 2023
e2e/04-dotSol-on-path/contracts/ERC20.sol/Foo.sol.sol Outdated Show resolved Hide resolved
e2e/test.js Outdated Show resolved Hide resolved
@@ -1,12 +1,24 @@
## [3.3.9] - TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem to belong to this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the old changelog and added this pr as well
The point is to have it up to date and update it on every change after this one

e2e/test.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@dbale-altoros
Copy link
Collaborator Author

@fvictorio
I corrected all issues you requested, some of them belong to the original coder.
The changelog is modified because I added this fix and also corrected miss information of previous version
Do you think it can be approved so we can move on ?
Thanks!

@dbale-altoros dbale-altoros merged commit 93b28e2 into master Feb 7, 2023
@dbale-altoros dbale-altoros deleted the fix/dirs-with-sol-extension branch February 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants