[ New Rule ] No unused imports

[juanpcapurro]

I've modified both openzeppelin-contracts and exactly to manually add this rule and check for false positives, couldn't find any in the current implementation. However, I'm concerned I might be forgetting to register some usage regarding inline assembly or some other less-used feature, so feedback is of course appreciated on that.

as always, see git history for details.

[dbale-altoros]

@juanpcapurro This is a cool rule! Thanks for that.
This is marked as draft... not sure if it's not finished yet, or you put it that way because it depends on the previous PR

[juanpcapurro]

@juanpcapurro This is a cool rule! Thanks for that. This is marked as draft... not sure if it's not finished yet, or you put it that way because it depends on the previous PR

Hi Diego, this PR is not in a mergable state sadly, since it still has many false positives yet. so far I've found the implementation errors out when an imported name is used as:

• type for
  • variable inside a function
  • struct definition
• value for
  • revert statement
  • accessing one if its members

and also has the following errors:

• reports original name when aliased name is not used

so a full review isn't in order yet. However, I'd of course greatly appreciate feedback on how I'm approaching the fix, if I'm organizing the code right, those kinds of things.

Small chores, such as not repeating myself for the different errors that have the same message, I'll probably fix later when I have the entire feature figured out though.

edit: the way I'm looking for false positives is by running the linter against a 'real world' codebase and checking manually. I'd love to hear on better ways to do it (either because it's faster or because the assertions can more easily be part of our codebase) if you have any ideas

[dbale-altoros]

Ok, no worries... You made such great contributions here... I cannot say other thing than thank you.
I don't know how much time I will be given to approach next tasks on solhint... as soon as I have some spare time I'll try to give you some feedback (if any)

[juanpcapurro]

@fvictorio @dbale-altoros ✨ should be ready for review now ✨

[dbale-altoros]

I tested it and seems pretty tight

[0xCourtney]

Great to see this rule being added, any idea on when the next release will be?

[juanpcapurro]

Great to see this rule being added, any idea on when the next release will be?

This rule is already released in solhint-community 3.5.1, where a few devs and myself are continuing development

[dbale-altoros]

@0xCourtney
We are going to fix as many issues as we can to provide an updated version
I have no fix date for next release but it will be soon

[dbale-altoros]

@juanpcapurro Como estas ?
Te consulto algo.
Veo que esta regla asi como esta codeada tiene varios falsos positivos que fueron arreglados en la version de community
Te molestaria si tomo los fixes de ese repo para esta regla asi la dejamos bien aca tambien ?

Gracias y disculpa la molestia