Add --quiet option #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t filter only error from linter results, and it was modified execMainAction() function to add the quiet option
fvictorio
suggested changes
Aug 29, 2018
solhint.js
Outdated
| @@ -17,6 +17,11 @@ function init() { | |||
| .description('Linter for Solidity programming language') | |||
| .action(execMainAction); | |||
|
|
|||
| program | |||
| .usage('[options] <file> [...other_files]') | |||
| .option('-q, --quiet', 'report errors only - default: false') | |||
There was a problem hiding this comment.
This is duplicating the previous block. I think you just need to add the .option line in that block.
There was a problem hiding this comment.
Perfect, I will modify it.
solhint.js
Outdated
| @@ -39,6 +44,12 @@ function execMainAction() { | |||
| const reportLists = program.args.filter(_.isString).map(processPath); | |||
| const reports =_.flatten(reportLists); | |||
|
|
|||
| if (program.quiet) { | |||
| console.log('::::Quiet mode enabled - filtering out warnings::::'); | |||
There was a problem hiding this comment.
I don't think that we should log anything here.
solhint.js
Outdated
| * @returns {LintResult[]} The filtered results. | ||
| **/ | ||
| function getErrorResults(reporter) { | ||
| const reporterErrors = reporter[0].reports.filter(i => i.severity === 2); |
There was a problem hiding this comment.
This is short and unlikely to be reused, I would do it inline.
There was a problem hiding this comment.
I agree, its a good observation.
…g when quiet option in enable.
fvictorio
reviewed
Aug 30, 2018
solhint.js
Outdated
| @@ -17,6 +17,9 @@ function init() { | |||
| .description('Linter for Solidity programming language') | |||
| .action(execMainAction); | |||
|
|
|||
| program | |||
| .option('-q, --quiet', 'report errors only - default: false'); | |||
There was a problem hiding this comment.
This line should be chained after line 16.
solhint.js
Outdated
| * @returns {LintResult[]} The filtered results. | ||
| **/ | ||
| function getErrorResults(reporter) { | ||
| return reporter[0].reports.filter(i => i.severity === 2); |
There was a problem hiding this comment.
Sorry, I wasn't clear about this. I meant that the function should be removed and the filter inlined in the if (program.quiet) block.
…MainAction(). Move new --quiet option declaration to the correct place.
fvictorio
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was added --quiet (-q) option that allows to report errors only, filtering out warnings reports.
Its resolves an item of Issue #5
To do this, it was modified execMainAction(), and it was added a function that filter errors reports.
Type of change