Exclude abi.encodeX calls from func-named-parameters #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbale-altoros - I pushed up a commit that I think fixes the linting issues of CI, but I'm not sure how to re-trigger the jobs. Any idea? |
I need to do that... already passed all of the CI tests... great job |
|
@0xCLARITY this week there will be a new release with this addition |
|
@dbale-altoros - any ETA on a new release? |
|
@0xCLARITY yes sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solhint regularly complains about the
named-parametersrule when all I'm doing is throwing a bunch of data intoabi.encode()orabi.encodePacked().Rather than annotating every single
abi.encodeX()call with a//solhint-disable- I think it makes more sense to excludeabi.encodeX()calls from this rule at the rule implementation.Tested locally on the contract I'm currently writing and works as expected.