Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snake case now allows for a (single) leading underscore. #93

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Snake case now allows for a (single) leading underscore. #93

merged 3 commits into from
Dec 21, 2018

Conversation

nventuro
Copy link
Contributor

Related to #90.

Mixed case already allows for this, but uppercase snake case doesn't. The rationale is that the style rule should allow it, and then other (to be implemented) rules should decide whether or not its appropriate depending on some other conditions (e.g. allowed -or enforced- on private members, disallowed on public, etc.).

@coveralls
Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage increased (+0.005%) to 99.532% when pulling fbfc4f0 on nventuro:leading-underscore-snake-case into f389547 on protofire:master.

Copy link
Contributor

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@pablofullana pablofullana merged commit e3aa88f into protofire:master Dec 21, 2018
@nventuro nventuro deleted the leading-underscore-snake-case branch December 21, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants