Remove exchange merge transition config #11452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Sep 15, 2022
| } | ||
| if isExecutionBlock { | ||
| log.Debug("PoS transition is complete, no longer checking for configuration changes") | ||
| return |
There was a problem hiding this comment.
Note that as soon as we have a merge block, we'll exit from this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Post merge clean up
What does this PR do? Why is it needed?
It removes the exchange transition configuration between Prysm and the EL clients. This piece of code will never be relevant and used. From now on, Prysm will sync though the merge transition through initial sync, this means the exchange transition config for TTD is no longer relevant. This only applies for regular sync
Which issues(s) does this PR fix?
N/A
Other notes for review