Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz ssz round trip #14006

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

bshastry
Copy link
Contributor

What type of PR is this?

Other (adds fuzzer)

What does this PR do? Why is it needed?

This PR adds a new fuzzer for testing ssz roundtrip coding. It is needed to increase test coverage.

Which issues(s) does this PR fix?

None

Other notes for review

Incorporates earlier feedback from private PR.

@bshastry bshastry requested a review from a team as a code owner May 16, 2024 09:02
@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

beacon-chain/p2p/encoder/ssz_test.go Outdated Show resolved Hide resolved
beacon-chain/p2p/encoder/ssz_test.go Outdated Show resolved Hide resolved
@prestonvanloon
Copy link
Member

Please run bazel run //:gazelle

Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@saolyn saolyn added this pull request to the merge queue May 21, 2024
Merged via the queue into prysmaticlabs:develop with commit 3df3e84 May 21, 2024
17 checks passed
fredriksvantes added a commit to fredriksvantes/documentation-1 that referenced this pull request Jul 3, 2024
**Name**: Bhargava Shastry
**Project**: Ethereum Foundation
**Team**: Protocol Security (EF)
**Joined**: 01/01/2023
**Link to relevant work**: [https://github.com/bshastry](https://github.com/bshastry)
**Summary of their work/eligibility**: Bhargava has been working full time in the EF since January 2019. He was working full-time as a security engineer for the Solidity team full-time until the end of 2023. In January 2023, he moved to the Protocol security team while still supporting Solidity. For the past six months he has been working full time to secure the Protocol by writing fuzzers and auditing the network layer. His current focus is the consensus later clients.
Some of his contributions include
* private fuzzers for go-libp2p, go-multistream, go-multiformat, rust-libp2p, ethereum_ssz
* Prysm (prysmaticlabs/prysm#14006), 
* public fuzzers for the Solidity compiler (https://github.com/ethereum/solidity/pulls?q=is%3Apr+author%3Abshastry+is%3Aclosed)
* Issues reported in Solidity compiler (https://github.com/ethereum/solidity/issues/created_by/bshastry)

Bhargava will have done his 6 months of full time protocol work on the 1st of August.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants