Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Gateway Removal #14089

Merged
merged 95 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
123e289
wip passing e2e
james-prysm Jun 6, 2024
dcaefd2
reverting temp comment
james-prysm Jun 6, 2024
3385c42
remove unneeded comments
james-prysm Jun 6, 2024
ec0c7e8
Merge branch 'develop' into gateway-removal
james-prysm Jun 6, 2024
b9de353
fixing merge errors
james-prysm Jun 6, 2024
6b6206e
fixing more bugs from merge
james-prysm Jun 6, 2024
7959bab
fixing test
james-prysm Jun 6, 2024
bf623e2
WIP moving code around and fixing tests
james-prysm Jun 6, 2024
46f274f
unused linting
james-prysm Jun 6, 2024
c761443
gaz
james-prysm Jun 6, 2024
c80f8e4
temp removing these tests as we need placeholder/wrapper APIs for the…
james-prysm Jun 7, 2024
cfbc2e4
attempting to remove dependencies to gRPC gateway , 1 mroe left in de…
james-prysm Jun 10, 2024
8f012e6
Merge branch 'develop' into gateway-removal
james-prysm Jun 10, 2024
109d283
Merge branch 'develop' into gateway-removal
james-prysm Jun 11, 2024
b6ba98c
renaming flags and other gateway services to http
james-prysm Jun 11, 2024
e1ef6ff
goimport
james-prysm Jun 11, 2024
5927bc4
fixing deepsource
james-prysm Jun 11, 2024
105685f
Merge branch 'develop' into gateway-removal
james-prysm Jun 12, 2024
18a7204
Merge branch 'develop' into gateway-removal
james-prysm Jun 12, 2024
20cc6c6
git mv
james-prysm Jun 13, 2024
b637ddf
merging in gateway changes needed
james-prysm Jun 13, 2024
327c7e0
Merge branch 'develop' into gateway-removal
james-prysm Jun 13, 2024
d415e8e
Update validator/package/validator.yaml
james-prysm Jun 14, 2024
2b7f795
Update validator/package/validator.yaml
james-prysm Jun 14, 2024
8ea3902
Update cmd/beacon-chain/flags/base.go
james-prysm Jun 14, 2024
cac35b8
Update cmd/beacon-chain/flags/base.go
james-prysm Jun 14, 2024
602178d
Update cmd/beacon-chain/flags/base.go
james-prysm Jun 14, 2024
dc6e2e1
Merge branch 'develop' into gateway-removal
james-prysm Jun 14, 2024
19f631a
addressing feedback
james-prysm Jun 14, 2024
63019ee
Merge branch 'develop' into gateway-removal
james-prysm Jun 14, 2024
3116e95
missed lint
james-prysm Jun 14, 2024
ca81e6b
renaming import
james-prysm Jun 14, 2024
b8de65c
Merge branch 'develop' into gateway-removal
james-prysm Jun 14, 2024
9789d90
reversal based on feedback
james-prysm Jun 14, 2024
3257fad
fixing web ui registration
james-prysm Jun 18, 2024
c396910
don't require mux handler
james-prysm Jun 18, 2024
48f00a1
gaz
james-prysm Jun 20, 2024
3859fa7
Merge branch 'develop' into gateway-removal
james-prysm Jun 20, 2024
6355a98
Merge branch 'develop' into gateway-removal
james-prysm Jun 20, 2024
41ad4d9
Merge branch 'develop' into gateway-removal
james-prysm Jun 21, 2024
3734fbe
removing gRPC service from validator completely, merged with http ser…
james-prysm Jun 21, 2024
65ce6ff
updating go.sum
james-prysm Jun 21, 2024
3279e37
linting
james-prysm Jun 21, 2024
4bb6182
trailing white space
james-prysm Jun 21, 2024
b94f21f
realized there was more cleanup i could do with code reuse
james-prysm Jun 21, 2024
6d0fe18
adding wrapper for routes
james-prysm Jun 22, 2024
fe83dae
Merge branch 'develop' into gateway-removal
james-prysm Jun 25, 2024
83adabe
Merge branch 'develop' into gateway-removal
james-prysm Jun 25, 2024
8b4ade6
Merge branch 'develop' into gateway-removal
james-prysm Jun 26, 2024
f40d275
Merge branch 'develop' into gateway-removal
james-prysm Jun 26, 2024
f689adc
reverting version
james-prysm Jun 27, 2024
86a56a3
fixing dependencies from merging develop
james-prysm Jun 27, 2024
32e5886
gaz
james-prysm Jun 27, 2024
3351929
Merge branch 'develop' into gateway-removal
james-prysm Jun 27, 2024
ca7b103
fixing unit test
james-prysm Jun 27, 2024
2602973
Merge branch 'develop' into gateway-removal
james-prysm Jun 28, 2024
ee83126
fixing dependencies
james-prysm Jun 28, 2024
4a197b7
Merge branch 'develop' into gateway-removal
james-prysm Jun 28, 2024
1687e9c
Merge branch 'develop' into gateway-removal
james-prysm Jun 29, 2024
3a6d1c0
Merge branch 'develop' into gateway-removal
james-prysm Jun 30, 2024
ae4dd2e
reverting unit test
james-prysm Jul 1, 2024
c7df8b7
Merge branch 'develop' into gateway-removal
james-prysm Jul 1, 2024
c04b29c
Merge branch 'develop' into gateway-removal
james-prysm Jul 1, 2024
07acf9a
Merge branch 'develop' into gateway-removal
james-prysm Jul 2, 2024
aa20399
fixing conflict
james-prysm Jul 2, 2024
56f764d
Merge branch 'develop' into gateway-removal
james-prysm Jul 2, 2024
b522911
Merge branch 'develop' into gateway-removal
james-prysm Jul 3, 2024
93b85b3
Merge branch 'develop' into gateway-removal
james-prysm Jul 12, 2024
3ab32d7
Merge branch 'develop' into gateway-removal
james-prysm Jul 15, 2024
f11b41c
Merge branch 'develop' into gateway-removal
james-prysm Jul 15, 2024
62d40c4
Merge branch 'develop' into gateway-removal
james-prysm Jul 19, 2024
a793b5e
Merge branch 'develop' into gateway-removal
james-prysm Jul 30, 2024
2e1df79
Merge branch 'develop' into gateway-removal
james-prysm Aug 14, 2024
7e79c55
Merge branch 'develop' into gateway-removal
james-prysm Aug 28, 2024
4261dec
updating change log
james-prysm Aug 28, 2024
afb9fb7
Update log.go
james-prysm Aug 28, 2024
ade93e2
gaz
james-prysm Aug 28, 2024
499144f
Update api/server/httprest/server.go
james-prysm Aug 29, 2024
1810c0c
addressing some feedback
james-prysm Aug 29, 2024
7b8b042
Merge branch 'develop' into gateway-removal
james-prysm Aug 29, 2024
fa7e259
forgot to remove deprecated flag in usage
james-prysm Aug 29, 2024
894ca7b
gofmt
james-prysm Aug 30, 2024
097bafb
fixing test
james-prysm Aug 30, 2024
95c1570
fixing deepsource issue
james-prysm Aug 30, 2024
9df43fc
Merge branch 'develop' into gateway-removal
james-prysm Aug 30, 2024
3dac48b
moving deprecated flag and adding timeout handler
james-prysm Aug 30, 2024
362f3f0
missed removal of a flag
james-prysm Aug 30, 2024
1ba0ac9
fixing test:
james-prysm Aug 30, 2024
0169f1f
Update CHANGELOG.md
james-prysm Sep 3, 2024
2442589
addressing feedback
james-prysm Sep 3, 2024
31776b6
Merge branch 'develop' into gateway-removal
james-prysm Sep 3, 2024
72dddf2
updating comments based on feedback
james-prysm Sep 3, 2024
87aad16
removing unused field for now, we can add it back in if we need to us…
james-prysm Sep 3, 2024
23493b7
removing unused struct
james-prysm Sep 3, 2024
e9d53cd
changing api-timeout flag based on feedback
james-prysm Sep 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@ alias(
visibility = ["//visibility:public"],
)

# Protobuf gRPC gateway compiler
alias(
name = "grpc_gateway_proto_compiler",
actual = "@com_github_grpc_ecosystem_grpc_gateway_v2//protoc-gen-grpc-gateway:go_gen_grpc_gateway",
visibility = ["//visibility:public"],
)

gometalinter(
name = "gometalinter",
config = "//:.gometalinter.json",
Expand Down
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,17 @@ The format is based on Keep a Changelog, and this project adheres to Semantic Ve
- Electra: Updated block publishing beacon APIs to support Electra.
- "Submitted builder validator registration settings for custom builders" log message moved to debug level.
- config: Genesis validator root is now hardcoded in params.BeaconConfig()
- `grpc-gateway-host` is renamed to http-host. The old name can still be used as an alias.
- `grpc-gateway-port` is renamed to http-port.
- `grpc-gateway-corsdomain` is renamed to http-cors-domain.
- `api-timeout` is changed from int flag to duration flag, default value updated.

### Deprecated

- `--disable-grpc-gateway` flag is deprecated due to grpc gateway removal.
- `--enable-experimental-state` flag is deprecated. This feature is now on by default. Opt-out with `--disable-experimental-state`.

### Removed

- removed gRPC Gateway

### Fixed

Expand Down
212 changes: 0 additions & 212 deletions api/gateway/gateway.go

This file was deleted.

107 changes: 0 additions & 107 deletions api/gateway/gateway_test.go

This file was deleted.

5 changes: 0 additions & 5 deletions api/gateway/log.go

This file was deleted.

30 changes: 0 additions & 30 deletions api/gateway/modifiers.go

This file was deleted.

Loading
Loading