EIP-7549: Aggregation gRPC metods #14115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
eip-7549-aggregate-rpc
branch
2 times, most recently
from
67456af
to
f194f6f
Compare
rkapka
added
Ready For Review
beacon-chain/rpc/core/validator.go
Outdated
Comment on lines
291
to
308
| var fields logrus.Fields | ||
| if agg.Version() >= version.Electra { | ||
| fields = logrus.Fields{ | ||
| "slot": data.Slot, | ||
| "committeeCount": att.CommitteeBitsVal().Count(), | ||
| "committeeIndices": att.CommitteeBitsVal().BitIndices(), | ||
| "validatorIndex": attAndProof.GetAggregatorIndex(), | ||
| "aggregatedCount": att.GetAggregationBits().Count(), | ||
| } | ||
| } else { | ||
| fields = logrus.Fields{ | ||
| "slot": data.Slot, | ||
| "committeeIndex": data.CommitteeIndex, | ||
| "validatorIndex": attAndProof.GetAggregatorIndex(), | ||
| "aggregatedCount": att.GetAggregationBits().Count(), | ||
| } | ||
| } | ||
| log.WithFields(fields).Debug("Broadcasting aggregated attestation and proof") |
There was a problem hiding this comment.
Consider wrapping this whole thing in a statement to see if debug logging is even enabled.
if log.GetLevel() >= logrus.DebugLevel {
var fields logrus.Fields
...
log.WithFields(fields).Debug(...)
}We should probably start doing this around debug logging to avoid unnecessary computation around field metadata
rkapka
added
Blocked
rkapka
force-pushed
the
eip-7549-aggregate-rpc
branch
from
f194f6f
to
5d8320e
Compare
rkapka
force-pushed
the
eip-7549-aggregate-rpc
branch
from
5d8320e
to
2c41217
Compare
rkapka
added
Ready For Review
prestonvanloon
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements the following Electra gRPC functions:
SubmitAggregateSelectionProofElectraSubmitSignedAggregateSelectionProofElectra