More tracing in the validator client #14125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
prestonvanloon
previously approved these changes
Jun 20, 2024
rkapka
force-pushed
the
more-tracing-in-vc
branch
from
c616bd9
to
1fcc029
Compare
rkapka
force-pushed
the
more-tracing-in-vc
branch
from
1fcc029
to
f8afde5
Compare
It has zero* side effects unless you're running with *zero means a few micro seconds to check check if the span should be metered or not. I don't think it's entirely "free" but it's so small that it shouldn't be noticeable |
prestonvanloon
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing in the validator client is currently rare therefore not very useful. Especially there is no tracing in the
beacon-apipackage.