Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for mjs #218

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Fix types for mjs #218

merged 4 commits into from
Jun 13, 2023

Conversation

Kamahl19
Copy link
Contributor

When using moduleResolution other then old node (node16, nodenext, bundler) there is a TS error:

Could not find a declaration file for module '@supabase-cache-helpers/postgrest-react-query'.
There are types at 'node_modules/@supabase-cache-helpers/postgrest-react-query/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@supabase-cache-helpers/postgrest-react-query' library may need to update its package.json or typings.

Here is more context egoist/tsup#760 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: 6034414

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@supabase-cache-helpers/postgrest-react-query Patch
@supabase-cache-helpers/storage-react-query Patch
@supabase-cache-helpers/postgrest-fetcher Patch
@supabase-cache-helpers/postgrest-filter Patch
@supabase-cache-helpers/postgrest-mutate Patch
@supabase-cache-helpers/postgrest-shared Patch
@supabase-cache-helpers/storage-fetcher Patch
@supabase-cache-helpers/storage-mutate Patch
@supabase-cache-helpers/postgrest-swr Patch
@supabase-cache-helpers/storage-swr Patch
@supabase-cache-helpers/examples/react-query Patch
@supabase-cache-helpers/examples/swr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
supabase-cache-helpers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 7:03pm
supabase-cache-helpers-swr-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 7:03pm

@vercel
Copy link

vercel bot commented Jun 13, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @psteinroe on Vercel.

@psteinroe first needs to authorize it.

@psteinroe
Copy link
Owner

thanks for fixing it! can you add a changeset with pnpm changeset to release a new patch version?

@Kamahl19
Copy link
Contributor Author

@psteinroe done

.changeset/loud-beers-sell.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #218 (6034414) into main (7d4e428) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         132      132           
  Lines        1720     1720           
  Branches      395      395           
=======================================
  Hits         1703     1703           
  Misses         17       17           
Flag Coverage Δ
postgrest-fetcher 100.00% <ø> (ø)
postgrest-filter 99.49% <ø> (ø)
postgrest-mutate 100.00% <ø> (ø)
postgrest-react-query 97.94% <ø> (ø)
postgrest-swr 97.40% <ø> (ø)
storage-fetcher 100.00% <ø> (ø)
storage-mutate 100.00% <ø> (ø)
storage-react-query 100.00% <ø> (ø)
storage-swr 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@psteinroe psteinroe merged commit 1d6dd4c into psteinroe:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants