#156 - Added skip_types and optimize options to rpm_sync #158
Conversation
chtaylo2
changed the title
plugins/modules/rpm_sync.py
Outdated
| @@ -106,6 +126,18 @@ def main(): | |||
| mirror = module.params["sync_policy"] == "mirror_complete" | |||
| parameters = {"mirror": mirror} | |||
|
|
|||
| parameters = {"optimize": module.params["optimize"]} | |||
There was a problem hiding this comment.
you are overwriting what we already collected in parameters here. This cannot possibly be correct.
There was a problem hiding this comment.
Good call out, I'll fix that. I also realized there's no test for the sync_policy key:pair. I'll proactively add that in.
There was a problem hiding this comment.
I guess you can fold that into the same update calls, no?
There was a problem hiding this comment.
Yep, exactly. I'll do that
|
Please add |
|
Can you please squash the commits? Did you know that running |
|
Rebase pushed to squash previous commits |
|
Looks good now. But we need some engineering on the commit message. |
Got it. I misread your request above to add "more" fix details to the commit message. Glad to see you want this limited and details to remain in the issue tracker. Commit message changed. |
Well, i don't want to push too hard. Also there is not much more one can say anyway. But I am a big fan of good commit messages (https://cbea.ms/git-commit/) because that's the only thing really persisting. And i hate how GH UI is trying hard to draw every attention away from commit messages. |
#156
Adding support for "skip_types" and "optimize" options to rpm_sync. Created tests inside "rpm_sync.yaml". Finally, refreshed the fixtures to reference the new tests.
I've run the full set of tests and all are passing, 100%.
Thanks,
Chris