(FACT-2817) Only invalidate session cache on clear and reset. #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins please test this on all |
|
CLA signed by all contributors. |
BogdanIrimie
force-pushed
the
FACT-2817
branch
2 times, most recently
from
3d4df32
to
caf290c
Compare
BogdanIrimie
force-pushed
the
FACT-2817
branch
from
caf290c
to
bb6357e
Compare
|
Jenkins please test this on all |
oanatmaria
approved these changes
Oct 8, 2020
Filipovici-Andrei
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SessionCacheis used internal to store resolver values. If a resolver is called multiple times, we only resolve once the data and all subsequent request to that resolver, will hit the cache.Problem
The current implementation invalidates this session cache after each request (to_hash, value, []), but Facter 3 invalidates this cache only on
resetandclear.Solution
Invalidate the session cache only on
resetandclear