(SDK-285) Add --auto-correct flag to validators that support it #104
Conversation
| @@ -1,7 +1,8 @@ | |||
|
|
|||
| shared_context 'in a new module' do |name| | |||
| before(:all) do | |||
| system("pdk new module #{name} --skip-interview") || raise | |||
| output = `pdk new module #{name} --skip-interview` | |||
There was a problem hiding this comment.
I'm not sure this captures stderr, appending 2>&1 should work on all platforms
| @@ -1,7 +1,8 @@ | |||
|
|
|||
| shared_context 'in a new module' do |name| | |||
| before(:all) do | |||
| system("pdk new module #{name} --skip-interview") || raise | |||
| output = `pdk new module #{name} --skip-interview 2>&1` | |||
There was a problem hiding this comment.
| @@ -1,7 +1,8 @@ | |||
|
|
|||
| shared_context 'in a new module' do |name| | |||
| before(:all) do | |||
| system("pdk new module #{name} --skip-interview") || raise | |||
| output = `pdk new module #{name} --skip-interview 2>&1` | |||
| raise "Failed to create test module:\n#{output}" unless File.directory?(name) | |||
There was a problem hiding this comment.
Then you can also raise here on the exit status returned from capture2e, and not rely on environmental factors.
|
Please also add a note to the README about how and where to use this flag. |
Sorry, didn't mean to imply that I was ignoring the lack of tests. I knew that puppet-lint integration was still a work in progress with open tickets and didn't want to duplicate work. |
|
Updated the |
|
Acceptance tests for puppet-lint integration added in #109. Once they are merged in, I'll come back to this and add acceptance tests for puppet-lint with --auto-correct. |
rodjek
force-pushed
the
sdk-285
branch
2 times, most recently
from
4fd8f8f
to
b3d5ad5
Compare
|
@DavidS acceptance tests added for auto-correcting puppet-lint problems |
This will just silently no-op for validators that don't support auto correction. There's no acceptance tests for puppet-lint integration at the moment, so I've only added an acceptance test for auto-correcting rubocop violations.