(GH-1083) Bump childprocess to '~> 4.0.0'; Disable @process.leader #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfrancrisko
requested review from
jpogran,
da-ar,
michaeltlombardi and
david22swan
Codecov Report
@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 91.27% 91.33% +0.06%
==========================================
Files 138 137 -1
Lines 5511 5506 -5
==========================================
- Hits 5030 5029 -1
+ Misses 481 477 -4
Continue to review full report at Codecov.
|
jpogran
approved these changes
Jun 10, 2021
|
Appears dependency resolution is timing out on Windows systems w/ Ruby 2.5. Cannot reproduce on macOS - will try to do so on an ABS provisioned Windows host |
Prior to this commit, it was observed on Windows Server 2016, 2019 Github Actions instances that invoking the pdk would result in ACCESS_DENIED errors. When the ChildProcess.leader parameter is set to true, it will set the `CREATE_BREAKAWAY_FROM_JOB` and `JOB_OBJECT_LIMIT_BREAKAWAY_OK` flags in the Win32. This is not required in Windows > Server 2008 / 7 and can potentially cause issues when Task Scheduler attempts to schedule a job that invokes a program with insufficient privileges. This commit also bumps `childprocess` to `~> 4.0.0` and `hitimes` to `2.0.0` to resolve dependency issues after bumping `childprocess`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was observed on Windows Server 2016, 2019
Github Actions instances that invoking the pdk would result in
ACCESS_DENIED errors.
When the ChildProcess.leader parameter is set to true, it will set
the
CREATE_BREAKAWAY_FROM_JOBandJOB_OBJECT_LIMIT_BREAKAWAY_OKflags in the Win32. This is not required in Windows > Server 2008 / 7
and can potentially cause issues when Task Scheduler attempts to
schedule a job that invokes a program with insufficient privileges.
This commit also bumps
childprocessto~> 4.0.0andhitimesto
2.0.0to resolve dependency issues after bumpingchildprocessCloses: #1083